From 2fe5759cdfa69506e32a28ecd47a76255bcd33e3 Mon Sep 17 00:00:00 2001 From: iris Date: Mon, 16 Nov 2026 18:12:01 +0100 Subject: [PATCH] swarm ui: the send button's off rule is a tested function --- .../swarm-ui/src/agent/terminal/AgentInputForm.tsx | 3 ++- .../packages/swarm-ui/src/agent/terminal/command-menu.ts | 8 ++++++++ frontend/packages/swarm-ui/test/command-menu.test.mjs | 8 ++++++++ 3 files changed, 18 insertions(+), 1 deletion(-) diff --git a/frontend/packages/swarm-ui/src/agent/terminal/AgentInputForm.tsx b/frontend/packages/swarm-ui/src/agent/terminal/AgentInputForm.tsx index 3e3ad7cd6..0ca26e2df 100644 --- a/frontend/packages/swarm-ui/src/agent/terminal/AgentInputForm.tsx +++ b/frontend/packages/swarm-ui/src/agent/terminal/AgentInputForm.tsx @@ -29,6 +29,7 @@ import { enterSends, matchCommands, menuQuery, + sendDisabled, textToSend, moveSelection, type AgentCommand, @@ -135,7 +136,7 @@ export function AgentInputForm({ agentName }: { agentName: string }) { type="submit" aria-label="send" title="send" - disabled={submitting || body.trim() === ""} + disabled={sendDisabled(body, submitting)} aria-busy={submitting || undefined} > {submitting ? : } diff --git a/frontend/packages/swarm-ui/src/agent/terminal/command-menu.ts b/frontend/packages/swarm-ui/src/agent/terminal/command-menu.ts index 3daa31e1f..43231e7fd 100644 --- a/frontend/packages/swarm-ui/src/agent/terminal/command-menu.ts +++ b/frontend/packages/swarm-ui/src/agent/terminal/command-menu.ts @@ -119,3 +119,11 @@ export function textToSend(text: string): string { const trimmed = text.trim(); return menuQuery(trimmed) === null ? text : trimmed; } + +/** + * Whether the send button is off: while a send is under way, or when the box + * holds nothing but whitespace. + */ +export function sendDisabled(text: string, submitting: boolean): boolean { + return submitting || text.trim() === ""; +} diff --git a/frontend/packages/swarm-ui/test/command-menu.test.mjs b/frontend/packages/swarm-ui/test/command-menu.test.mjs index 53166c9a1..98816a741 100644 --- a/frontend/packages/swarm-ui/test/command-menu.test.mjs +++ b/frontend/packages/swarm-ui/test/command-menu.test.mjs @@ -9,6 +9,7 @@ import { matchCommands, menuQuery, moveSelection, + sendDisabled, splitName, textToSend, } from "../src/agent/terminal/command-menu.ts"; @@ -127,3 +128,10 @@ test("any other message goes as it is", () => { assert.equal(textToSend("fix /etc/hosts"), "fix /etc/hosts"); assert.equal(textToSend(" "), " "); }); + +test("send is off while sending and for a box with only whitespace", () => { + assert.equal(sendDisabled("", false), true); + assert.equal(sendDisabled(" \n ", false), true); + assert.equal(sendDisabled("hi", true), true); + assert.equal(sendDisabled("hi", false), false); +});