Watch
0
0
Fork
You've already forked hyperhive
0

agents get read, not write, on their own agent-configs repo; an existing grant is left alone

This commit is contained in:
damocles 2026-11-15 16:20:54 +01:00 • committed by mara
commit 07c66e3a1c

View file

@ -54,15 +54,21 @@ fn holds_read(p: &RepoCollaboratorPermission) -> bool {
impl Client {
/// Make `agent` a **read** collaborator on `internal/docs` — the whole job
/// of the `GrantDocsRead` node. Idempotent, and never lowers: an agent that
/// already holds read or more (write, admin, owner) is left as it is, since
/// the add endpoint would overwrite the permission. Needs the forge user to
/// exist.
/// of the `GrantDocsRead` node. Idempotent, and never lowers: see
/// [`Self::grant_read`]. Needs the forge user to exist.
pub async fn grant_docs_read(&self, agent: &str) -> Result<()> {
self.grant_read(SHARED_ORG, SHARED_DOCS_REPO, agent).await
}
/// Make `user` a **read** collaborator on `owner/repo` unless it already
/// holds read or more (write, admin, owner), which is left as it is: the
/// add endpoint would overwrite the permission, so adding at read would
/// lower a write grant an operator made.
pub(super) async fn grant_read(&self, owner: &str, repo: &str, user: &str) -> Result<()> {
match self
.api
.call(|api| {
api.repo_get_repo_permissions(SHARED_ORG, SHARED_DOCS_REPO, agent)
api.repo_get_repo_permissions(owner, repo, user)
.into_future()
})
.await
@ -71,18 +77,12 @@ impl Client {
Ok(_) => {}
Err(e) if is_not_found(&e) => {}
Err(e) => {
return Err(e).with_context(|| {
format!("read {agent}'s permission on {SHARED_ORG}/{SHARED_DOCS_REPO}")
});
return Err(e)
.with_context(|| format!("read {user}'s permission on {owner}/{repo}"));
}
}
self.add_collaborator_to(
SHARED_ORG,
SHARED_DOCS_REPO,
agent,
AddCollaboratorOptionPermission::Read,
)
.await
self.add_collaborator_to(owner, repo, user, AddCollaboratorOptionPermission::Read)
.await
}
/// Whether `agent` is a collaborator on `internal/docs` now.